Skip to content

refactor: display default values for options in spark help#10288

Merged
paulbalandan merged 1 commit into
codeigniter4:4.8from
paulbalandan:cli-option-defaults
Jun 11, 2026
Merged

refactor: display default values for options in spark help#10288
paulbalandan merged 1 commit into
codeigniter4:4.8from
paulbalandan:cli-option-defaults

Conversation

@paulbalandan

Copy link
Copy Markdown
Member

Description
The modern spark help prints the default value for an argument if its value is optional. For parity, this PR adds the same default value printing for value-accepting options. Flag options and negatable options still do not show the defaults because their sentinel values are meaningless in help output.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@github-actions github-actions Bot added the 4.8 PRs that target the `4.8` branch. label Jun 8, 2026
@paulbalandan paulbalandan added the refactor Pull requests that refactor code label Jun 8, 2026
@paulbalandan paulbalandan merged commit f889329 into codeigniter4:4.8 Jun 11, 2026
90 of 92 checks passed
@paulbalandan paulbalandan deleted the cli-option-defaults branch June 11, 2026 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.8 PRs that target the `4.8` branch. refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants