fix: preserve enclosing stream filter when using MockInputOutput#10307
Merged
paulbalandan merged 1 commit intoJun 12, 2026
Merged
Conversation
michalsn
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a test uses
MockInputOutputwhile it (or its base) also usesStreamFilterTrait, the mock's internaladdStreamFilters()/removeStreamFilters()calls tore down the trait'sSTDOUT/STDERRfilters and left them removed. Any CLI output produced after theMockInputOutputinteraction (for example intearDown()) then bypassed capture and leaked to the console.MockInputOutputnow snapshots the sharedCITestStreamFilterstate (filter presence and buffer) before attaching its own filters and restores it afterward, so an enclosingStreamFilterTraitkeeps capturing once the mock is done. AddsCITestStreamFilter::hasOutputFilter()/hasErrorFilter()accessors and a regression test covering both thefwriteandinputpaths.Checklist: