fix: skip already-translated keys in spark lang:find#10308
Merged
paulbalandan merged 1 commit intoJun 12, 2026
Conversation
michalsn
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
spark lang:finddecided whether a key was "new" by loading onlyapp/Language/<locale>/<File>.php. But at runtimelang()resolves a key through the FileLocator across every namespace (framework, packages, and app). As a result, keys already shipped by the framework or a package (for exampleErrors.*fromsystem/Language) were treated as new:--show-newlisted them as missing translations.app/Languageas untranslated placeholders (the dotted key string), which then overrode the framework's real translations at runtime (e.g. error pages rendering the literalErrors.pageNotFound).This PR makes the finder compare found keys against the translations resolvable from all namespaces, mirroring how
lang()resolves at runtime. A key is now considered new only when it cannot be resolved from any loaded language file. Write mode writes only genuinely-new keys plus the app's own existing keys, so framework- or package-provided translations are never copied intoapp/Language.Added regression tests for both the
--show-newand write paths, and a note in the localization guide.Checklist: