Skip to content

refactor: always use multiple filters#7903

Merged
kenjis merged 8 commits into
codeigniter4:4.5from
kenjis:multipleFilters-default
Sep 14, 2023
Merged

refactor: always use multiple filters#7903
kenjis merged 8 commits into
codeigniter4:4.5from
kenjis:multipleFilters-default

Conversation

@kenjis

@kenjis kenjis commented Sep 6, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added breaking change Pull requests that may break existing functionalities 4.5 labels Sep 6, 2023
@kenjis kenjis marked this pull request as draft September 6, 2023 02:55
@kenjis kenjis added the refactor Pull requests that refactor code label Sep 6, 2023
@kenjis kenjis mentioned this pull request Sep 6, 2023
Merged
2 tasks
@kenjis kenjis added the docs needed Pull requests needing documentation write-ups and/or revisions. label Sep 6, 2023
@kenjis kenjis force-pushed the multipleFilters-default branch 2 times, most recently from 9d5be64 to 0174873 Compare September 13, 2023 06:11
@kenjis

kenjis commented Sep 13, 2023

Copy link
Copy Markdown
Member Author

Rebased and added docs.

@kenjis kenjis marked this pull request as ready for review September 13, 2023 06:11
@kenjis kenjis removed the docs needed Pull requests needing documentation write-ups and/or revisions. label Sep 13, 2023
@kenjis kenjis marked this pull request as draft September 13, 2023 06:16
@kenjis kenjis force-pushed the multipleFilters-default branch from 0174873 to 4eafee1 Compare September 13, 2023 06:26
@kenjis kenjis force-pushed the multipleFilters-default branch from 4eafee1 to 581a5db Compare September 13, 2023 06:28
@kenjis kenjis marked this pull request as ready for review September 13, 2023 06:28
@MGatner

MGatner commented Sep 13, 2023

Copy link
Copy Markdown
Member

Hmm same Coveralls issue is happening here now.

PHP Fatal error: Uncaught Error: Class "Config\Autoload" not found in /home/runner/work/CodeIgniter4/CodeIgniter4/system/Test/Mock/MockAutoload.php:16

MGatner
MGatner approved these changes Sep 13, 2023
View reviewed changes

@MGatner MGatner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice docs

@kenjis kenjis merged commit 28fe6ff into codeigniter4:4.5 Sep 14, 2023
@kenjis kenjis deleted the multipleFilters-default branch September 14, 2023 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatner MGatner MGatner approved these changes

Assignees

No one assigned

Labels

breaking change Pull requests that may break existing functionalities refactor Pull requests that refactor code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @MGatner
⚡