feat: domparser - ability to write more advanced expressions#7946
Merged
Conversation
Member
Author
|
Not sure why, but unrelated to this PR checks fail. |
kenjis
added
enhancement
Member
|
@michalsn This is an enhancement. Please change the base branch to |
michalsn
force-pushed
the
feat/domparser-seeXPath
branch
from
9b172ed to
9ff890c
Compare
Member
Author
|
@kenjis Done. |
kenjis
reviewed
Sep 17, 2023
Co-authored-by: kenjis <kenji.uui@gmail.com>
kenjis
approved these changes
Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
DomParserclass is great for simple expressions, but if we want to check something more complicated, it unfortunately doesn't give us that option.Therefore, this PR adds the ability to write an expression that will be executed directly by the
DOMXPathclass.This way we can handle more advanced scenarios, like searching for nested elements in the DOM.
Checklist: