Skip to content

feat: spark filter:check shows "Required Filters"#8236

Merged
kenjis merged 2 commits into
codeigniter4:4.5from
kenjis:feat-filter-check-required-filters
Dec 2, 2023
Merged

feat: spark filter:check shows "Required Filters"#8236
kenjis merged 2 commits into
codeigniter4:4.5from
kenjis:feat-filter-check-required-filters

Conversation

@kenjis

@kenjis kenjis commented Nov 20, 2023

Copy link
Copy Markdown
Member

Needs #8235

Description
Follow-up #8053

$ ./spark filter:check GET /

CodeIgniter v4.4.3 Command Line Tool - Server Time: 2023-11-20 06:15:09 UTC+00:00

+--------+-------+----------------------+-------------------------------+
| Method | Route | Before Filters       | After Filters                 |
+--------+-------+----------------------+-------------------------------+
| GET    | /     | forcehttps pagecache | pagecache performance toolbar |
+--------+-------+----------------------+-------------------------------+

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.5 labels Nov 20, 2023
@kenjis kenjis marked this pull request as draft November 20, 2023 06:28
@kenjis kenjis force-pushed the feat-filter-check-required-filters branch 3 times, most recently from 6ae7391 to cf962fc Compare November 20, 2023 07:15
@github-actions github-actions Bot added the stale Pull requests with conflicts label Nov 27, 2023
@github-actions

Copy link
Copy Markdown

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

@kenjis kenjis force-pushed the feat-filter-check-required-filters branch from cf962fc to 631fdea Compare November 29, 2023 04:21
@kenjis kenjis removed the stale Pull requests with conflicts label Nov 29, 2023
@kenjis kenjis marked this pull request as ready for review November 29, 2023 04:23
@kenjis

kenjis commented Nov 29, 2023

Copy link
Copy Markdown
Member Author

Rebased to resolve conflict.

@kenjis kenjis merged commit e0eb27c into codeigniter4:4.5 Dec 2, 2023
@kenjis kenjis deleted the feat-filter-check-required-filters branch December 2, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement PRs that improve existing functionalities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants