Skip to content

refactor: remove unused exception classes#8468

Merged
kenjis merged 2 commits into
codeigniter4:4.5from
kenjis:remove-unused-exceptions
Jan 30, 2024
Merged

refactor: remove unused exception classes#8468
kenjis merged 2 commits into
codeigniter4:4.5from
kenjis:remove-unused-exceptions

Conversation

@kenjis

@kenjis kenjis commented Jan 27, 2024

Copy link
Copy Markdown
Member

Description

  • remove unused exception classes

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code 4.5 labels Jan 27, 2024

@paulbalandan paulbalandan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be on the changelog?

@michalsn michalsn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think anyone uses it, but yes - we should mention it in the changelog.

@kenjis kenjis force-pushed the remove-unused-exceptions branch from 99d71cb to 89cdde2 Compare January 28, 2024 00:18
@kenjis

kenjis commented Jan 28, 2024

Copy link
Copy Markdown
Member Author

Added changelog.

@kenjis kenjis force-pushed the remove-unused-exceptions branch from 89cdde2 to c16c65e Compare January 28, 2024 02:32
@kenjis kenjis merged commit 50cc0df into codeigniter4:4.5 Jan 30, 2024
@kenjis kenjis deleted the remove-unused-exceptions branch January 30, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants