Skip to content

feat: 404 Override sets 404 by default#8535

Merged
kenjis merged 2 commits into
codeigniter4:4.5from
kenjis:feat-404override-sets-404
Feb 17, 2024
Merged

feat: 404 Override sets 404 by default#8535
kenjis merged 2 commits into
codeigniter4:4.5from
kenjis:feat-404override-sets-404

Conversation

@kenjis

@kenjis kenjis commented Feb 11, 2024

Copy link
Copy Markdown
Member

Description
The 404 Override feature should set 404 by default, because it is for 404 pages.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added enhancement PRs that improve existing functionalities breaking change Pull requests that may break existing functionalities 4.5 labels Feb 11, 2024
@kenjis kenjis force-pushed the feat-404override-sets-404 branch from c49f923 to a493db6 Compare February 11, 2024 23:42
@kenjis kenjis merged commit b72ae46 into codeigniter4:4.5 Feb 17, 2024
@kenjis kenjis deleted the feat-404override-sets-404 branch February 17, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Pull requests that may break existing functionalities enhancement PRs that improve existing functionalities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants