Skip to content

feat: Support faker modifiers on Fabricator#8671

Merged
kenjis merged 3 commits into
codeigniter4:4.5from
paulbalandan:fabricator-modifiers
Mar 30, 2024
Merged

feat: Support faker modifiers on Fabricator#8671
kenjis merged 3 commits into
codeigniter4:4.5from
paulbalandan:fabricator-modifiers

Conversation

@paulbalandan

Copy link
Copy Markdown
Member

Description
Closes #6812

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan force-pushed the fabricator-modifiers branch from 95932e1 to cc8c99e Compare March 28, 2024 14:16

@michalsn michalsn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature.

@kenjis kenjis added enhancement PRs that improve existing functionalities 4.5 labels Mar 28, 2024
Comment thread user_guide_src/source/testing/fabricator.rst Outdated
@kenjis

kenjis commented Mar 28, 2024

Copy link
Copy Markdown
Member

@paulbalandan paulbalandan force-pushed the fabricator-modifiers branch from cc8c99e to 4610481 Compare March 29, 2024 13:28
@kenjis

kenjis commented Mar 30, 2024

Copy link
Copy Markdown
Member

Can you rebase to check GA checks?

@paulbalandan paulbalandan force-pushed the fabricator-modifiers branch from 4610481 to 31afcfa Compare March 30, 2024 09:17

@kenjis kenjis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis merged commit 3574196 into codeigniter4:4.5 Mar 30, 2024
@paulbalandan paulbalandan deleted the fabricator-modifiers branch March 31, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement PRs that improve existing functionalities

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants