Skip to content

[4.5] fix: TypeError in Filters #8683

Merged
kenjis merged 3 commits into
codeigniter4:4.5from
kenjis:fix-Filters-4.5
Mar 30, 2024
Merged

[4.5] fix: TypeError in Filters #8683
kenjis merged 3 commits into
codeigniter4:4.5from
kenjis:fix-Filters-4.5

Conversation

@kenjis

@kenjis kenjis commented Mar 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description

  • fix TypeError
  • update test code

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

kenjis added 3 commits March 30, 2024 09:33
@kenjis
fix: TypeError in Filters
492425a 
TypeError: urldecode(): Argument #1 ($string) must be of type string, null given
@kenjis
test: update FiltersTest assertion
f7c46dd
@kenjis
test: update ConfigCheckTest assertions
cceb1e8
@kenjis kenjis changed the title fix: TypeError in Filters [4.5] fix: TypeError in Filters Mar 30, 2024
@kenjis kenjis added 4.5 bug Verified issues on the current code behavior or pull requests that will fix them labels Mar 30, 2024
@kenjis kenjis merged commit ee8e117 into codeigniter4:4.5 Mar 30, 2024
@kenjis kenjis deleted the fix-Filters-4.5 branch March 30, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @paulbalandan
⚡