Skip to content

refactor: system/CLI/BaseCommand.php#8741

Merged
kenjis merged 2 commits into
codeigniter4:developfrom
mcsaygili:refactor-system-CLI-BaseCommand.php
Apr 11, 2024
Merged

refactor: system/CLI/BaseCommand.php#8741
kenjis merged 2 commits into
codeigniter4:developfrom
mcsaygili:refactor-system-CLI-BaseCommand.php

Conversation

@mcsaygili

@mcsaygili mcsaygili commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

Description
See #8732

  • replace empty()
  • add types

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Apr 9, 2024
@mcsaygili

Copy link
Copy Markdown
Contributor Author

Failed at PHPUnit / Others (8.3) / Sanity Tests (pull_request) step.
After adding .gitkeep file to /CodeIgniter4/writable/debugbar/ passed.
Should I add the .gitkeep ?

@kenjis

kenjis commented Apr 9, 2024

Copy link
Copy Markdown
Member

Sorry, now PHPUnit checks fail.
It is addressed in #8740.

@kenjis

kenjis commented Apr 10, 2024

Copy link
Copy Markdown
Member

I merged #8740.
Can you rebase this PR?
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch
If you have questions, feel free to ask.

@kenjis

kenjis commented Apr 10, 2024

Copy link
Copy Markdown
Member

@mcsaygili

mcsaygili commented Apr 10, 2024

Copy link
Copy Markdown
Contributor Author

I tried using an IDE, but using the command line as you mentioned to be easier. Can you look into it?

Comment thread system/CLI/BaseCommand.php Outdated
@kenjis kenjis merged commit e14e145 into codeigniter4:develop Apr 11, 2024
@kenjis

kenjis commented Apr 11, 2024

Copy link
Copy Markdown
Member

Thank you!

Leaning git commands is very useful. git commands are the only common language for Git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants