fix: [ErrorException] Undefined array key in spark phpini:check#8804
Merged
kenjis merged 2 commits intoApr 21, 2024
Merged
Conversation
If a setting does not exists, ini_get_all() does not have the key.
ddevsr
approved these changes
Apr 19, 2024
samsonasik
reviewed
Apr 19, 2024
samsonasik
approved these changes
Apr 19, 2024
Contributor
Member
Author
|
The PHP ini default for Since what to do with these settings depends on the situation, If enabling them improves performance, they should be enabled。 If we set the recommended values, we need to prove that it improves performance in most use cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Fixes #8803
Checklist: