Skip to content

refactor: remove unused path parameter on PhpStreamWrapper::stream_open()#8926

Merged
samsonasik merged 1 commit into
codeigniter4:developfrom
samsonasik:chore-stream-wrapper
May 30, 2024
Merged

refactor: remove unused path parameter on PhpStreamWrapper::stream_open()#8926
samsonasik merged 1 commit into
codeigniter4:developfrom
samsonasik:chore-stream-wrapper

Conversation

@samsonasik

Copy link
Copy Markdown
Member

Description

Detected by latest rector rule: RemoveUnusedPublicMethodParameterRector

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik samsonasik changed the title chore: remove unused path parameter on PhpStreamWrapper::stream_open() refactor: remove unused path parameter on PhpStreamWrapper::stream_open() May 30, 2024
@samsonasik

Copy link
Copy Markdown
Member Author

Ready to merge 👍

@ddevsr ddevsr added the refactor Pull requests that refactor code label May 30, 2024
@samsonasik

Copy link
Copy Markdown
Member Author

Thank you @michalsn for the review, let's merge 👍

@samsonasik samsonasik merged commit 19e62ac into codeigniter4:develop May 30, 2024
@samsonasik samsonasik deleted the chore-stream-wrapper branch May 30, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants