Skip to content

fix: [QueryBuilder] select() with RawSql may cause TypeError#9009

Merged
kenjis merged 7 commits into
codeigniter4:developfrom
kenjis:fix-qb-select-rawsql
Jul 1, 2024
Merged

fix: [QueryBuilder] select() with RawSql may cause TypeError#9009
kenjis merged 7 commits into
codeigniter4:developfrom
kenjis:fix-qb-select-rawsql

Conversation

@kenjis

@kenjis kenjis commented Jun 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Description
Fixes #9007

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

kenjis added 3 commits June 28, 2024 08:55
@kenjis
test: add test for select() with RawSql
43ce135
@kenjis
fix: select() may cause TypeError
1962e8c 
TypeError: trim(): Argument #1 ($string) must be of type string, CodeIgniter\Database\RawSql given
@kenjis
refactor: rename variable name
73d67fb
@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer labels Jun 28, 2024
@kenjis kenjis mentioned this pull request Jun 28, 2024
Closed
maniaba
maniaba suggested changes Jun 28, 2024
View reviewed changes
Comment thread tests/system/Database/Builder/SelectTest.php Outdated
@kenjis kenjis requested a review from maniaba June 28, 2024 10:22
maniaba
maniaba reviewed Jun 28, 2024
View reviewed changes
Comment thread system/Database/BaseBuilder.php Outdated
@kenjis kenjis requested a review from maniaba June 28, 2024 11:28
@kenjis kenjis merged commit e7cb689 into codeigniter4:develop Jul 1, 2024
@kenjis kenjis deleted the fix-qb-select-rawsql branch July 1, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

+2 more reviewers

@datamweb datamweb datamweb approved these changes

@maniaba maniaba maniaba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: [QueryBuilder] select() TypeError: trim(): Argument #1 ($string) must be of type string, CodeIgniter\Database\RawSql given

4 participants

@kenjis @michalsn @datamweb @maniaba
⚡