Skip to content

refactor: enable AddFunctionVoidReturnTypeWhereNoReturnRector to add void to functions#9014

Merged
samsonasik merged 2 commits into
codeigniter4:developfrom
samsonasik:refactor-void-function
Jun 30, 2024
Merged

refactor: enable AddFunctionVoidReturnTypeWhereNoReturnRector to add void to functions#9014
samsonasik merged 2 commits into
codeigniter4:developfrom
samsonasik:refactor-void-function

Conversation

@samsonasik

Copy link
Copy Markdown
Member

Description

enable AddFunctionVoidReturnTypeWhereNoReturnRector to add void to functions

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik

Copy link
Copy Markdown
Member Author

Ready to merge 👍

@samsonasik

Copy link
Copy Markdown
Member Author

Thank you @kenjis for the review, let's merge ;)

@samsonasik samsonasik merged commit 01f52ef into codeigniter4:develop Jun 30, 2024
@samsonasik samsonasik deleted the refactor-void-function branch June 30, 2024 09:45
@kenjis kenjis added the refactor Pull requests that refactor code label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants