fix: respect complex language strings when using validation#9201
Merged
Conversation
Contributor
|
I tried it and it seems to work fine. Thanks @michalsn |
Member
Author
|
@dgvirtual Ok, thank you for testing it out. |
d41ec7d to
2bb985c
Compare
paulbalandan
approved these changes
Nov 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where complex language strings in the validation class are not handled properly.
The problem was that in the validation class, we were forming the final message using the
str_replace()function, instead of using the built-in solutions thatMessageFormatter::formatMessagegives us.Checklist: