Skip to content

refactor: enable rector code quality level 14#9232

Merged
samsonasik merged 1 commit into
codeigniter4:developfrom
samsonasik:refactor-enable-rector-code-quality-level-14
Oct 21, 2024
Merged

refactor: enable rector code quality level 14#9232
samsonasik merged 1 commit into
codeigniter4:developfrom
samsonasik:refactor-enable-rector-code-quality-level-14

Conversation

@samsonasik

Copy link
Copy Markdown
Member

Description

Apply SimplifyDeMorganBinaryRector for Simplify negated conditions with de Morgan theorem

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik

Copy link
Copy Markdown
Member Author

Ready to merge 👍

@MGatner MGatner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@samsonasik

samsonasik commented Oct 21, 2024

Copy link
Copy Markdown
Member Author

Thank you @MGatner @paulbalandan for the review, let's merge ;)

@samsonasik samsonasik merged commit ba62eae into codeigniter4:develop Oct 21, 2024
@samsonasik samsonasik deleted the refactor-enable-rector-code-quality-level-14 branch October 21, 2024 00:52
@kenjis kenjis added the refactor Pull requests that refactor code label Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants