fix: Postgre\Connection::reconnect() TypeError in pg_ping()#9279
Merged
Conversation
michalsn
requested changes
Nov 14, 2024
michalsn
left a comment
michalsn
left a comment
Member
There was a problem hiding this comment.
Looks good. Please add a changelog entry under Bugs Fixed section: https://github.com/codeigniter4/CodeIgniter4/blob/develop/user_guide_src/source/changelogs/v4.5.6.rst
michalsn
reviewed
Nov 14, 2024
michalsn
added
the
bug
ping-yee
force-pushed
the
9043_pg_ping()
branch
from
3fd2cb9 to
3876bdd
Compare
samsonasik
approved these changes
Nov 18, 2024
michalsn
requested changes
Nov 18, 2024
michalsn
left a comment
michalsn
left a comment
Member
There was a problem hiding this comment.
Can we change a changelog entry to be more specific?
michalsn
changed the title
Postgre\Connection::reconnect() TypeError in pg_ping()
Member
|
Hi @ping-yee , one last rebase please and we can merge this. And fixing the conflict. Thank you! |
paulbalandan
changed the title
Postgre\Connection::reconnect() TypeError in pg_ping()Postgre\Connection::reconnect() TypeError in pg_ping()
paulbalandan
approved these changes
Nov 29, 2024
|
👋 Hi, @ping-yee! |
paulbalandan
force-pushed
the
9043_pg_ping()
branch
from
57edd82 to
0c9799f
Compare
Member
|
Thank you, @ping-yee . I rebased your branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #9043
Checklist: