Skip to content

refactor: use baseURI instead of base_uri#9296

Merged
paulbalandan merged 2 commits into
codeigniter4:developfrom
paulbalandan:curl-base-uri
Dec 1, 2024
Merged

refactor: use baseURI instead of base_uri#9296
paulbalandan merged 2 commits into
codeigniter4:developfrom
paulbalandan:curl-base-uri

Conversation

@paulbalandan

Copy link
Copy Markdown
Member

Description
Fixes #9265
Replaces and closes #9280

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan

Copy link
Copy Markdown
Member Author

The test is useless because (1) in PHP, arrays with duplicate keys always retains the last key, and (2) CURLRequest::parseOptions() only checks for baseURI key not base_uri.

@ddevsr ddevsr added the refactor Pull requests that refactor code label Dec 1, 2024
@paulbalandan paulbalandan merged commit 4c8b782 into codeigniter4:develop Dec 1, 2024
@paulbalandan paulbalandan deleted the curl-base-uri branch December 1, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: base_uri or baseURI in curlrequest?

3 participants