SearchCursor.matches() doesn't work properly if query is /.*/

[soswow]

SearchCursor.matches used inside SearchCursor.find().
When you call .find() for the first time it returns first row, like

this.pos == {
  from: {ch: 0, line: 0}, 
  to: {ch: 18, line: 0},
  match: ["First row here"]
}

But when you ask .find() for the second time it returns

this.pos == {
  from: {ch: 18, line: 0}, 
  to: {ch: 18, line: 0},
  match: [""]
}

And all following calls will return the same output.
So if I use it in the client code like this (to find all matches for example):

var cursor = getSearchCursor(cm, state.query);
while (cursor.findNext()) {
  //Mark found item
}

Then I end pu with infinite loop on /.*/

[marijnh]

Well, yes, /.*/ matches everything, including the empty string, so obviously it'll keep on matching on that position, and never move forward. I'd argue this isn't a bug, but I agree that it's convenient if code can assume looping over matches doesn't produce an infinite loop.

Do you have a suggested solution?

[soswow]

I have it in my pull-request attached. (but I made pull request into adobe's clone.

[marijnh]

That seems like a nice and clean solution. Merged. I've also committed 1960b0d to address the same situation with string queries.