highlighting both tags#1653
Conversation
There was a problem hiding this comment.
If it is not a real tag hit, we don't need to loop through all the times.
|
I prefer the way things look when only the 'other' tag is highlighted, so I'm going to keep the addon in the distribution the way it is. |
|
but the check at 30th line will improve performance a lot. without that check it will mostly scan the document while user scrolls. |
|
Did you benchmark, or are you just making things up? I'm asking because my old code did the same thing, or at least it tried to do the same thing, and I can't see a reason why it should be broken. |
|
Whatever you have now is perfect. I am just trying to avoid unwanted scans. |
Some code changes to highlight both tags. I felt highlighting both tags are necessary when tags needs to be find by scrolling. What do you think ?