Conversation
414f68a to
ab10aa8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #521 +/- ##
==========================================
+ Coverage 78.08% 78.16% +0.07%
==========================================
Files 122 123 +1
Lines 11387 11541 +154
Branches 1728 1748 +20
==========================================
+ Hits 8892 9021 +129
- Misses 1793 1811 +18
- Partials 702 709 +7
|
ozangoktan
reviewed
Feb 26, 2025
write a test as well
BugGambit
approved these changes
Feb 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a simple utility class containing code for fetching configs from CDF. It's maybe a bit early for this, since I still don't have a perfectly clear idea of how it's going to be used, but most of the logic here makes sense in general, and is a foundation for future work.