Skip to content

Add utility for config loading#521

Merged
einarmo merged 4 commits intomasterfrom
config-source
Mar 3, 2025
Merged

Add utility for config loading#521
einarmo merged 4 commits intomasterfrom
config-source

Conversation

@einarmo
Copy link
Copy Markdown
Contributor

@einarmo einarmo commented Feb 19, 2025

Just a simple utility class containing code for fetching configs from CDF. It's maybe a bit early for this, since I still don't have a perfectly clear idea of how it's going to be used, but most of the logic here makes sense in general, and is a foundation for future work.

@einarmo einarmo requested a review from a team as a code owner February 19, 2025 10:08
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 85.18519% with 24 lines in your changes missing coverage. Please review.

Project coverage is 78.16%. Comparing base (bf8116d) to head (76aabe9).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ractorUtils/Unstable/Configuration/ConfigSource.cs 83.56% 17 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #521      +/-   ##
==========================================
+ Coverage   78.08%   78.16%   +0.07%     
==========================================
  Files         122      123       +1     
  Lines       11387    11541     +154     
  Branches     1728     1748      +20     
==========================================
+ Hits         8892     9021     +129     
- Misses       1793     1811      +18     
- Partials      702      709       +7     
Files with missing lines Coverage Δ
Cognite.Config/Configuration.cs 87.32% <100.00%> (+0.55%) ⬆️
...xtractorUtils/Unstable/DestinationUtilsUnstable.cs 64.07% <100.00%> (+0.43%) ⬆️
...ractorUtils/Unstable/Configuration/ConfigSource.cs 83.56% <83.56%> (ø)

... and 2 files with indirect coverage changes

@einarmo einarmo requested a review from ozangoktan February 27, 2025 07:11
Copy link
Copy Markdown
Contributor

@ozangoktan ozangoktan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@einarmo einarmo requested review from a team and BugGambit and removed request for a team February 28, 2025 08:16
@einarmo einarmo merged commit 8b44bc4 into master Mar 3, 2025
4 checks passed
@einarmo einarmo deleted the config-source branch March 3, 2025 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants