Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #522 +/- ##
==========================================
+ Coverage 78.10% 78.24% +0.13%
==========================================
Files 123 124 +1
Lines 11541 11748 +207
Branches 1748 1781 +33
==========================================
+ Hits 9014 9192 +178
- Misses 1817 1822 +5
- Partials 710 734 +24
🚀 New features to boost your workflow:
|
ozangoktan
reviewed
Mar 12, 2025
Contributor
ozangoktan
left a comment
There was a problem hiding this comment.
For the IIntegrationSink, I am starting to think sink may not be the best choice to describe it as. Isn't what it is doing something like an IOrchestratorIntegration rather than a sink adapting to an integration, which could mean other things than integrations api orchestrating the extractor.
Co-authored-by: Ozan Göktan <72358629+ozangoktan@users.noreply.github.com>
Contributor
Author
|
Let's do renaming the sink in a different PR, if we are doing it. It's a bit intrusive for this one. |
ozangoktan
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First take on a new base extractor class. Some more work goes into this in the next step, adding startup reporting and integrating things a bit more tightly, but this is a nice first draft that contains some of the core logic.
The base extractor has a few roles, currently:
As with the last iteration of the base extractor, it is intended to be used as a base class for user extractors.