Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #655 +/- ##
==========================================
- Coverage 78.07% 77.98% -0.10%
==========================================
Files 136 136
Lines 13228 13240 +12
Branches 1991 1993 +2
==========================================
- Hits 10328 10325 -3
- Misses 2063 2075 +12
- Partials 837 840 +3
🚀 New features to boost your workflow:
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a new ExtractorRunResult.RestartRequired state to the extractor runtime, allowing for clean shutdowns that still necessitate a restart, particularly when a configuration revision changes. The Run and BuildAndRunExtractor methods have been updated to handle this new state, including logging relevant information and setting appropriate backoff. Unit tests were also updated to reduce backoff times and explicitly set the restart policy to OnError for testing config change scenarios. There are no review comments to address.
Hmnt39
left a comment
There was a problem hiding this comment.
Is this restart trigger will only be done on remote config changes or local remote will also do it ?
If connection config is set to local, then it will do it. If connection config is set to 'no connection', Then it will not do it. I think this is correct behaviour. |
Currently, we restart on config change only if restart policy is 'always' but we also want to restart for other cases to support integrations.