Skip to content

Add vWeekday.ical_value for the Component.decoded() polymorphy #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stevepiercy merged 4 commits into from
May 13, 2026
Merged

Add vWeekday.ical_value for the Component.decoded() polymorphy #1360

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
67aa6d8
Add `vWeekday.ical_value` for the `Component.decoded()` polymorphy
mvanhorn May 5, 2026
ac8322a
docs(weekday): apply review suggestions and add changelog entry
mvanhorn May 6, 2026
41e60ee
Merge branch 'main' into vtext-ical-value
stevepiercy May 13, 2026
73a2779
Merge branch 'main' into vtext-ical-value
stevepiercy May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/icalendar/prop/recur/weekday.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,14 @@ def from_ical(cls, ical):
except Exception as e:
raise ValueError(f"Expected weekday abbreviation, got: {ical}") from e

@property
def ical_value(self) -> str:
"""The weekday value (e.g. ``MO``, ``+2TH``, ``-1SU``).
Comment thread
stevepiercy marked this conversation as resolved.
Outdated

See :rfc:`5545#section-3.3.10` for the ``BYDAY`` rule grammar.
Comment thread
stevepiercy marked this conversation as resolved.
Outdated
"""
return str(self)

@classmethod
def parse_jcal_value(cls, value: Any) -> Self:
"""Parse a jCal value for vWeekday.
Expand Down
8 changes: 8 additions & 0 deletions src/icalendar/tests/prop/test_vWeekday.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,11 @@ def test_error():
"""Error: Expected weekday abbrevation, got: -100MO"""
with pytest.raises(ValueError):
vWeekday.from_ical("-100MO")


def test_ical_value():
"""ical_value property returns the weekday string value."""
assert vWeekday("MO").ical_value == "MO"
assert vWeekday("+2TH").ical_value == "+2TH"
assert vWeekday("-1SU").ical_value == "-1SU"
assert isinstance(vWeekday("MO").ical_value, str)
⚡