Fix error of using urllib to download eigen from gitlab#1194
Merged
ahojnnes merged 2 commits intocolmap:devfrom Apr 10, 2021
Merged
Fix error of using urllib to download eigen from gitlab#1194ahojnnes merged 2 commits intocolmap:devfrom
ahojnnes merged 2 commits intocolmap:devfrom
Conversation
lucasthahn
pushed a commit
to tne-ai/colmap
that referenced
this pull request
Aug 17, 2022
Co-authored-by: Johannes Schönberger <joschonb@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
urllib.request.urlretrieve cannot download eigen from gitlab as mentioned in #973 .
This pull request solves this problem by using the requests library, but you need to install a third-party library requests in python 3 .
Before run build.py script, install requests by pip($ python -m pip install requests).
Installing Requests