Log the name of the file that causes Mat::Read() to checkfail#1923
Merged
ahojnnes merged 2 commits intocolmap:devfrom May 18, 2023
Merged
Log the name of the file that causes Mat::Read() to checkfail#1923ahojnnes merged 2 commits intocolmap:devfrom
ahojnnes merged 2 commits intocolmap:devfrom
Conversation
Some of the CHECK statements in Mat::Read() do not log the name of the file that triggers them. This can cause crashes that are difficult to debug.
Contributor
Author
|
The Windows build has failed for reasons not related to this commit. |
Contributor
|
Thanks for the PR, will merge once I find time to resolve the Windows CI issue. |
Contributor
|
Merged with main branch, should pass also windows tests now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the CHECK statements in Mat::Read() do not log the name of the file that triggers them. This can cause crashes that are difficult to debug.