Conversation
sarlinpe
commented
May 25, 2024
|
|
||
| const double tri_angle = CalculateTriangulationAngle( | ||
| proj_center1, proj_center2, point3D.xyz); | ||
| EXPECT_GE(tri_angle, DegToRad(kMinTriAngleDeg)); |
Member
Author
There was a problem hiding this comment.
This test sometimes fails on mac and Windows with the previous value of 1°. It seems that the sampling of camera poses doesn't constrain them to have a sufficient angle.
ahojnnes
reviewed
May 26, 2024
ahojnnes
reviewed
May 26, 2024
ahojnnes
reviewed
May 26, 2024
ahojnnes
reviewed
May 26, 2024
ahojnnes
reviewed
May 26, 2024
ahojnnes
reviewed
May 26, 2024
Contributor
|
Looks great to me. I assume most of the code in the ObservationManager is untouched and just moved from Reconstruction/Image classes? Have you run through a dataset and checked that it produces the exact same number of final observations? |
Member
Author
|
PTAL. I have indeed mostly moved around code without change of logic. I have checked that the result is identical in terms of reconstruction statistics. |
Contributor
|
Perfect, thanks a lot. |
ahojnnes
approved these changes
May 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the filtering logic in
Reconstructionas well as the SfM-specific data inImage, such as the visibility pyramid. The logic is unchanged except one minor point: I removed thenum_observationscolumn in the GUI database image viewer because this field is now only available during reconstruction. It is anyway mostly redundant withnum_points2D.