Skip to content

Fix unused variable warnings under MSVC #2884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahojnnes merged 1 commit into from
Nov 4, 2024
Merged

Fix unused variable warnings under MSVC #2884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/colmap/scene/reconstruction.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ size_t Reconstruction::NumPoints3D() const { return points3D_.size(); }
const struct Camera& Reconstruction::Camera(const camera_t camera_id) const {
try {
return cameras_.at(camera_id);
} catch (const std::out_of_range& e) {
} catch (const std::out_of_range&) {
throw std::out_of_range(
StringPrintf("Camera with ID %d does not exist", camera_id));
}
Expand All @@ -285,7 +285,7 @@ const struct Camera& Reconstruction::Camera(const camera_t camera_id) const {
const class Image& Reconstruction::Image(const image_t image_id) const {
try {
return images_.at(image_id);
} catch (const std::out_of_range& e) {
} catch (const std::out_of_range&) {
throw std::out_of_range(
StringPrintf("Image with ID %d does not exist", image_id));
}
Expand All @@ -295,7 +295,7 @@ const struct Point3D& Reconstruction::Point3D(
const point3D_t point3D_id) const {
try {
return points3D_.at(point3D_id);
} catch (const std::out_of_range& e) {
} catch (const std::out_of_range&) {
throw std::out_of_range(
StringPrintf("Point3D with ID %d does not exist", point3D_id));
}
Expand All @@ -304,7 +304,7 @@ const struct Point3D& Reconstruction::Point3D(
struct Camera& Reconstruction::Camera(const camera_t camera_id) {
try {
return cameras_.at(camera_id);
} catch (const std::out_of_range& e) {
} catch (const std::out_of_range&) {
throw std::out_of_range(
StringPrintf("Camera with ID %d does not exist", camera_id));
}
Expand All @@ -313,7 +313,7 @@ struct Camera& Reconstruction::Camera(const camera_t camera_id) {
class Image& Reconstruction::Image(const image_t image_id) {
try {
return images_.at(image_id);
} catch (const std::out_of_range& e) {
} catch (const std::out_of_range&) {
throw std::out_of_range(
StringPrintf("Image with ID %d does not exist", image_id));
}
Expand All @@ -322,7 +322,7 @@ class Image& Reconstruction::Image(const image_t image_id) {
struct Point3D& Reconstruction::Point3D(const point3D_t point3D_id) {
try {
return points3D_.at(point3D_id);
} catch (const std::out_of_range& e) {
} catch (const std::out_of_range&) {
throw std::out_of_range(
StringPrintf("Point3D with ID %d does not exist", point3D_id));
}
Expand Down
⚡