Conversation
|
Should also increment here: https://github.com/colmap/glomap/blob/main/cmake/FindDependencies.cmake#L38? |
|
Eventually, we should introduce a global_mapper option into colmap. This indeed becomes difficult to maintain in the long-term. Meanwhile, I don't think there is an ambition to support multiple versions of colmap. The only use case for not using the FetchContent approach is when one wants to make code changes to both glomap and colmap at the same time. |
|
The intention of this update was to support in glomap the newly introduced camera model (colmap/colmap#2786) and updated undistortion (colmap/colmap#2857) for Fisheye images. This workflow may need to be gone through repeatedly in the future when the base classes are updated. |
|
Thanks very much @sarlinpe ! |
|
Sorry but I just have time to look into it. Thank you so much @sarlinpe ! |
* Update to COLMAP HEAD * Bump COLMAP tag * Install gmock in CI * Apply clang-tidy only to GLOMAP headers * Fix clang-tidy regexp header filter * Make PoseLib a system include
4 participants
Update to colmap/colmap@3254263. I don't know how you want to handle older versions of COLMAP - maybe by creating a new release? Merging this into the COLMAP repos would definitely make this easier.