PR: Add colour.SpectralShape.from_array class method (constructor).#1322
Open
PR: Add colour.SpectralShape.from_array class method (constructor).#1322
colour.SpectralShape.from_array class method (constructor).#1322Conversation
tjdcs
force-pushed
the
feature/shape_from_array
branch
from
ce0caf1 to
715d256
Compare
KelSolaar
requested changes
Jan 7, 2025
Member
KelSolaar
left a comment
KelSolaar
left a comment
There was a problem hiding this comment.
Thanks, great idea!
I left a few minor comments that would be good to address.
| np.arange(0, 10 + 0.1, 0.1), | ||
| ) | ||
|
|
||
| def test_from_data(self) -> None: |
Member
There was a problem hiding this comment.
Major
test_from_data --> test_from_array/test_from_wavelengths
KelSolaar
changed the title
from_array class method (constructor) to SpectralShapecolour.SpectralShape.from_array class method (constructor).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a utility constructor for constructing a SpectralShape directly from a list of values.
Not sure if this is already available elsewhere, but if it is then perhaps this organization (placing the method inside the definition of SpectralShape) is better?