NEW: Add tegra variant for CUDA 12.9#151
Conversation
carterbox
requested review from
a team,
jakirkham and
leofang
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
jakirkham
left a comment
jakirkham
left a comment
There was a problem hiding this comment.
Thanks Daniel! 🙏
Had one comment below
Otherwise LGTM
recipe/build.sh
Outdated
| # Convert CUDAARCHS to NVCC_GENCODE if available | ||
| if [[ -n "${CUDAARCHS}" ]]; then | ||
| NVCC_GENCODE="" | ||
| IFS=';' read -ra ARCHS <<< "$CUDAARCHS" | ||
| for arch_spec in "${ARCHS[@]}"; do | ||
| # Remove any leading/trailing whitespace | ||
| arch_spec=$(echo "$arch_spec" | xargs) | ||
|
|
||
| # Parse architecture number and suffix (e.g., "87-real", "101f-virtual") | ||
| if [[ "$arch_spec" =~ ^([0-9]+)([a-z]*)-(real|virtual)$ ]]; then | ||
| arch_num="${BASH_REMATCH[1]}" | ||
| arch_suffix="${BASH_REMATCH[2]}" | ||
| code_type="${BASH_REMATCH[3]}" | ||
|
|
||
| # Build the full architecture string with suffix if present | ||
| full_arch="${arch_num}${arch_suffix}" | ||
|
|
||
| if [[ "$code_type" == "real" ]]; then | ||
| NVCC_GENCODE="${NVCC_GENCODE} -gencode=arch=compute_${full_arch},code=sm_${full_arch}" | ||
| elif [[ "$code_type" == "virtual" ]]; then | ||
| NVCC_GENCODE="${NVCC_GENCODE} -gencode=arch=compute_${arch_num},code=compute_${arch_num}" | ||
| fi | ||
| fi | ||
| done | ||
| # Trim leading space | ||
| export NVCC_GENCODE="${NVCC_GENCODE# }" | ||
| fi |
There was a problem hiding this comment.
Discussed this block with Daniel offline, our plan is to move this into the nvcc feedstock as another variable
There was a problem hiding this comment.
Upstream relevant code for choosing NVCC_GENCODE:
This reverts commit d9d1acc.
|
Hi! This is the friendly automated conda-forge-linting service. I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict. Please ping the 'conda-forge/core' team (using the |
|
@conda-forge-admin , please re-render |
|
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/20972777469. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
|
Thanks Daniel! 🙏 Most of the logs look reasonable so far Did spot the following in this log: This appears to be missing things like Also seeing this in the same log It looks like we may still be picking up the old compiler builds in some cases Could you please double check? |
|
Good catch! There's a bug in the nvcc feedstock such that the build number did not increase. |
|
Thanks Daniel! 🙏 Looks like those are now up. Let's give this another try @conda-forge-admin please restart CI |
|
Thanks Daniel! 🙏 |
3 participants
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)Depends on:
conda-forge/cuda-nvcc-feedstock#90
conda-forge/cuda-nvcc-feedstock#88
conda-forge/cuda-nvcc-feedstock#87