Correct task awaiting with ConfigureAwait(false) in Producer.

[Lev Dimov (levdimov)]

This fix resolves an issue when client code waits ProduceAsync synchronously (using .Result or .GetAwaiter().GetResult()). This fix is very useful for keeping backward compatability with legacy code which you cannot easily migrate to async. As I wrote here before 1.0.0 Producer code was returning tasks rather than awaiting them inside implementation.

I also added ConfigureAwaitChecker.Analyzer package so you will have warnings in future

[Deleted user (ghost)]

It looks like Lev Dimov (@levdimov) hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement here.

Once you've signed reply with [clabot:check] to prove it.

Appreciation of efforts,

clabot

[Deleted user (ghost)]

Confluent Inc. (@confluentinc) It looks like Lev Dimov (@levdimov) just signed our Contributor License Agreement. 👍

Always at your service,

clabot

[Matt Howlett (mhowlett)]

looks good except for unnecessary white space changes (these make it difficult to track what changes happened when). also, I'm not keen on the ConfigureAwaitChecker.Analyzer dependency. I don't know why it would be a problem, but as a rule of thumb, prefer to not to have dependencies unless critical. if you make those changes, LGTM. Thanks!

[Lev Dimov (levdimov)]

Sorry about whitespace changes, my IDE is removing trailing whitespaces automatically and I hide all whitespace changes in Git UI :)

Also I've removed ConfigureAwaitChecker.Analyzer. Personally, I don't see any problems with private dependencies, but you are the boss :)

Thank you!

[Matt Howlett (mhowlett)]

thanks! I also don't see any problem, but I don't have time to give it any thought and not including it is definitely 100% safe.

[Lev Dimov (levdimov)]

Matt Howlett (@mhowlett), may I ask you when these changes are going to be released?

[Matt Howlett (mhowlett)]

I've opened #968 so we can release asap - so hopefully soon, but there is some internal debate as to how to best do rapid releases moving forward. this is a test case for that.