Merged
Conversation
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
| type: s1-prod-ubuntu20-04-amd64-2 | ||
| prologue: | ||
| commands: | ||
| - sudo apt-get update |
Contributor
There was a problem hiding this comment.
Can we upgrade Ubuntu to 22.04 instead, it should have GCC 11
f0d33c9 to
561f2a7
Compare
Contributor
Author
|
Run with successful builds for every OS platform combination: https://semaphore.ci.confluent.io/workflows/07c183ce-cbd5-4a2f-95e6-5fc1bceef206?pipeline_id=58bce03e-17cf-416f-9b82-502b347fd988 |
82f5389 to
6a742db
Compare
6a742db to
275876f
Compare
Emanuele Sabellico (emasab)
approved these changes
Dec 12, 2024
Contributor
Emanuele Sabellico (emasab)
left a comment
There was a problem hiding this comment.
LGTM!
Emanuele Sabellico (emasab)
approved these changes
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using Nan::CopyablePersistentTraits causes substitution errors for node 18. However, we can just use Nan::Callback as it wraps the function for us properly.
Green run (for this green run I changed package.json version to 0.5.0-rc0-dev. I reverted this change before making this PR): https://semaphore.ci.confluent.io/workflows/2bd1ca0f-0d97-4b64-9d56-609ad652c240?pipeline_id=15879558-975b-4759-a151-8ea706f6d9c5
I ran tests manually to confirm.