feat(golang): pick patch version automatically#3016
Closed
phil9909 wants to merge 1 commit intocontainerbase:mainfrom
Closed
feat(golang): pick patch version automatically#3016phil9909 wants to merge 1 commit intocontainerbase:mainfrom
phil9909 wants to merge 1 commit intocontainerbase:mainfrom
Conversation
viceice
requested changes
Jul 30, 2024
Member
viceice
left a comment
viceice
left a comment
There was a problem hiding this comment.
I'll refactor this to typescript soon, so deferring this
Member
|
@phil9909 Please open a new discussion and write your full use-case. I'm closing this for now until we've a conclusion that we like to have this feature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it is required to specify the full go version
install-tool golang 1.22.5.With this change, the patch version can be left out:
install-tool golang 1.22and the latest available patch version will be installed.A test was added to ensure "1.20" will resolve to "1.20.14". As "1.20" is end of life, there should be no further patches and therefore the test should not break. I guess there is a small chance that the go team decides to patch "1.20", if a serious vulnerability is discovered. It's unlikely, as the EOL date is already several months ago.