feat: type ExO query filter parameters for Template, Experience, and Fragment [DX-935]#3013
Open
Tyler Pina (tylerpina) wants to merge 4 commits intofeat/exofrom
Open
feat: type ExO query filter parameters for Template, Experience, and Fragment [DX-935]#3013Tyler Pina (tylerpina) wants to merge 4 commits intofeat/exofrom
Tyler Pina (tylerpina) wants to merge 4 commits intofeat/exofrom
Conversation
|
Bito Automatic Review Skipped - Branch Excluded |
Tyler Pina (tylerpina)
force-pushed
the
dx-935-type-exo-query-filter-params
branch
from
c4ef6d0 to
8e9bea0
Compare
| order?: string | ||
| [key: string]: unknown | ||
| // SysFiltersSchema | ||
| 'sys.id'?: string |
Contributor
There was a problem hiding this comment.
I think we could make a shared filters type since these are identical, and use that for experiences and templates.
My bad on the PR description -- it missing information. Basically, we can also use the shared filters for component types and fragments in addition to experience and templates.
Tyler Pina (tylerpina)
force-pushed
the
dx-935-type-exo-query-filter-params
branch
from
8e9bea0 to
845a4f7
Compare
…X-935] Replace catch-all `[key: string]: unknown` in `TemplateQueryOptions` and `ExperienceQueryOptions` with 40 named fields mirroring the upstream `TemplateListFiltersSchema` / `ExperienceListFilterSchema` from `experiences-management-api-contract`: - SysFiltersSchema (31 fields): sys.id, createdBy/updatedBy/publishedBy, date range filters, version, archivedAt[exists] - TagFiltersSchema (3): metadata.tags.sys.id[in/all/nin] - TaxonomyConceptsFiltersSchema (4): metadata.concepts.sys.id[in/all/nin], metadata.concepts.descendants[in] - TextFiltersSchema (2): name, name[match] Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Tyler Pina (tylerpina)
force-pushed
the
dx-935-type-exo-query-filter-params
branch
from
845a4f7 to
5050307
Compare
Replace [key: string]: unknown catch-all in FragmentQueryOptions with the shared ExoQueryFilters type, consistent with Template and Experience. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Tyler Pina (tylerpina)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DX-935
Summary
ExoQueryFiltersinterface inlib/common-types.tsmirroring the four upstream filter schemas (SysFiltersSchema,TagFiltersSchema,TaxonomyConceptsFiltersSchema,TextFiltersSchema) fromexperiences-management-api-contract[key: string]: unknownescape hatches onComponentTypeQueryOptions,ExperienceQueryOptions, andTemplateQueryOptionswith typed intersections ofCursorPaginationParams & ExoQueryFilters & { order? }ExoQueryFiltersthe same way when its entity file is createdTest plan
npx tsc --noEmitpasses with no errorsnpm run test:unitsys.*,metadata.tags.*,metadata.concepts.*,name,name[match]) are accepted without errorGenerated with Claude Code