fix: align DesignPropertyValue with upstream schema refactor [DX-990]#3014
Merged
Tyler Pina (tylerpina) merged 2 commits intofeat/exofrom Apr 30, 2026
Merged
Conversation
…eeDesignPropertyValue [DX-990] DesignPropertyValue is now the canonical base (ManualDesignValue | DesignTokenValue only), matching upstream DesignPropertyValueSchema post INTEG-3511. New ComponentTreeDesignPropertyValue union covers pointer and dimensioned as siblings at the tree-node level. ComponentNode.designProperties updated accordingly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Bito Automatic Review Skipped - Branch Excluded |
|
|
||
| // For designProperties[].defaultValue (definition level) | ||
| // Upstream: DesignPropertyValueSchema (schema line 86-91) | ||
| // Upstream: DesignPropertyValueSchema — canonical value only (no pointer, no dimensioned) |
Contributor
There was a problem hiding this comment.
I think it's time to have these comments removed. If you think it would help for a future debugging session, maybe list the upstream mapping in the PR description? I'm okay without that too -- I think the naming is fairly close to the upstream schema that we won't need it.
Michael Pham (michaelphamcf)
approved these changes
Apr 30, 2026
Tyler Pina (tylerpina)
deleted the
dx-990-fix-design-property-value-types
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DX-990
Summary
DesignPropertyValueis now the canonical base type (ManualDesignValue | DesignTokenValueonly), matching upstreamDesignPropertyValueSchemapost INTEG-3511 (2026-03-26)ComponentTreeDesignPropertyValueunion introduced as the tree-node-level type —DesignPropertyPointerValueandDimensionedDesignPropertyValueare siblings of the canonical value, not nested inside itComponentNode.designPropertiesupdated toRecord<string, ComponentTreeDesignPropertyValue>Test plan
npx tsc --noEmitpasses with no errorsnpm run test:unit{ breakpoint: pointer }toDesignPropertyValueproduces a type errorComponentTreeDesignPropertyValueaccepts pointer, dimensioned record, and canonical value as siblingsGenerated with Claude Code