-
Notifications
You must be signed in to change notification settings - Fork 28
chore: switch to nx [EXT-7081] #2883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,29 +20,13 @@ runs: | |
| - name: Install Dependencies (Linux) | ||
| if: inputs.os != 'windows-latest' | ||
| shell: bash | ||
| run: npm ci && npm run bootstrap | ||
| run: npm ci | ||
|
|
||
| - name: Install Dependencies (Windows) | ||
| if: inputs.os == 'windows-latest' | ||
| shell: pwsh | ||
| run: | | ||
| npm ci | ||
| if ($LASTEXITCODE -eq 0) { | ||
| npm run bootstrap | ||
| } else { | ||
| exit $LASTEXITCODE | ||
| } | ||
|
|
||
| - name: Disable Nx daemon | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I assume this is all lerna nonsense and that's why it's being removed?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah, it was some suggestions around some of the lerna + nx stuff to help with the windows builds |
||
| if: inputs.os == 'windows-latest' | ||
| shell: pwsh | ||
| run: | | ||
| "NX_DAEMON=false" | Out-File -FilePath $env:GITHUB_ENV -Append | ||
|
|
||
| - name: Nx reset | ||
| if: inputs.os == 'windows-latest' | ||
| shell: pwsh | ||
| run: npx nx reset | ||
|
|
||
| - name: Build (Linux) | ||
| if: inputs.os != 'windows-latest' | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72,62 +72,51 @@ jobs: | |
| run: npm install -g npm@latest | ||
|
|
||
| - name: Install dependencies | ||
| run: npm ci && npm run bootstrap | ||
| run: npm ci | ||
|
|
||
| - name: Build | ||
| run: npm run build | ||
|
|
||
| - name: Version (main branch) | ||
| - name: Prepare release (main branch) | ||
| if: (github.event.workflow_run.head_branch || github.ref_name) == 'main' | ||
| run: npm run version | ||
| run: npm run prepare-release | ||
| env: | ||
| GITHUB_TOKEN: ${{ steps.vault.outputs.GITHUB_TOKEN }} | ||
| GH_TOKEN: ${{ steps.vault.outputs.GITHUB_TOKEN }} | ||
| NPM_TOKEN: ${{ steps.vault.outputs.GITHUB_PACKAGES_WRITE_TOKEN }} | ||
| NODE_AUTH_TOKEN: ${{ steps.vault.outputs.GITHUB_PACKAGES_WRITE_TOKEN }} | ||
| GIT_AUTHOR_NAME: ${{ steps.vault.outputs.GIT_COMMITTER_NAME }} | ||
| GIT_AUTHOR_EMAIL: ${{ steps.vault.outputs.GIT_COMMITTER_EMAIL }} | ||
| GIT_COMMITTER_NAME: ${{ steps.vault.outputs.GIT_COMMITTER_NAME }} | ||
| GIT_COMMITTER_EMAIL: ${{ steps.vault.outputs.GIT_COMMITTER_EMAIL }} | ||
|
|
||
| - name: Publish (main branch) | ||
| if: (github.event.workflow_run.head_branch || github.ref_name) == 'main' | ||
| run: npm run publish-packages | ||
| - name: Prepare release (canary branch) | ||
| if: (github.event.workflow_run.head_branch || github.ref_name) == 'canary' | ||
| run: npm run prepare-release:canary | ||
| env: | ||
| GITHUB_TOKEN: ${{ steps.vault.outputs.GITHUB_TOKEN }} | ||
| GH_TOKEN: ${{ steps.vault.outputs.GITHUB_TOKEN }} | ||
| NPM_TOKEN: ${{ steps.vault.outputs.GITHUB_PACKAGES_WRITE_TOKEN }} | ||
| NODE_AUTH_TOKEN: ${{ steps.vault.outputs.GITHUB_PACKAGES_WRITE_TOKEN }} | ||
| GIT_AUTHOR_NAME: ${{ steps.vault.outputs.GIT_COMMITTER_NAME }} | ||
| GIT_AUTHOR_EMAIL: ${{ steps.vault.outputs.GIT_COMMITTER_EMAIL }} | ||
| GIT_COMMITTER_NAME: ${{ steps.vault.outputs.GIT_COMMITTER_NAME }} | ||
| GIT_COMMITTER_EMAIL: ${{ steps.vault.outputs.GIT_COMMITTER_EMAIL }} | ||
|
|
||
| - name: Version (canary branch) | ||
| - name: Push release commit + tags (canary) | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. in order to support canary releases on a dist-tag other than latest in npm we need to separate some of the nx life cycle commands so that we can call This step pushes those commits |
||
| if: (github.event.workflow_run.head_branch || github.ref_name) == 'canary' | ||
| run: npm run version:canary | ||
| run: | | ||
| git push --follow-tags --no-verify --atomic | ||
| env: | ||
| GITHUB_TOKEN: ${{ steps.vault.outputs.GITHUB_TOKEN }} | ||
|
|
||
| - name: Publish (main branch) | ||
| if: (github.event.workflow_run.head_branch || github.ref_name) == 'main' | ||
| run: npm run publish-packages | ||
| env: | ||
| GITHUB_TOKEN: ${{ steps.vault.outputs.GITHUB_TOKEN }} | ||
| GH_TOKEN: ${{ steps.vault.outputs.GITHUB_TOKEN }} | ||
| NPM_TOKEN: ${{ steps.vault.outputs.GITHUB_PACKAGES_WRITE_TOKEN }} | ||
| NODE_AUTH_TOKEN: ${{ steps.vault.outputs.GITHUB_PACKAGES_WRITE_TOKEN }} | ||
| GIT_AUTHOR_NAME: ${{ steps.vault.outputs.GIT_COMMITTER_NAME }} | ||
| GIT_AUTHOR_EMAIL: ${{ steps.vault.outputs.GIT_COMMITTER_EMAIL }} | ||
| GIT_COMMITTER_NAME: ${{ steps.vault.outputs.GIT_COMMITTER_NAME }} | ||
| GIT_COMMITTER_EMAIL: ${{ steps.vault.outputs.GIT_COMMITTER_EMAIL }} | ||
| NPM_CONFIG_PROVENANCE: true | ||
|
|
||
| - name: Publish (canary branch) | ||
| if: (github.event.workflow_run.head_branch || github.ref_name) == 'canary' | ||
| run: npm run publish-packages:canary | ||
| env: | ||
| GITHUB_TOKEN: ${{ steps.vault.outputs.GITHUB_TOKEN }} | ||
| GH_TOKEN: ${{ steps.vault.outputs.GITHUB_TOKEN }} | ||
| NPM_TOKEN: ${{ steps.vault.outputs.GITHUB_PACKAGES_WRITE_TOKEN }} | ||
| NODE_AUTH_TOKEN: ${{ steps.vault.outputs.GITHUB_PACKAGES_WRITE_TOKEN }} | ||
| GIT_AUTHOR_NAME: ${{ steps.vault.outputs.GIT_COMMITTER_NAME }} | ||
| GIT_AUTHOR_EMAIL: ${{ steps.vault.outputs.GIT_COMMITTER_EMAIL }} | ||
| GIT_COMMITTER_NAME: ${{ steps.vault.outputs.GIT_COMMITTER_NAME }} | ||
| GIT_COMMITTER_EMAIL: ${{ steps.vault.outputs.GIT_COMMITTER_EMAIL }} | ||
| NPM_CONFIG_PROVENANCE: true | ||
|
|
||
| - name: Print lerna debug log | ||
| if: always() | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| //npm.pkg.github.com/:_authToken=${NODE_AUTH_TOKEN} | ||
| @contentful:registry=https://registry.npmjs.org | ||
| ignore-scripts=true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no longer need lerna bootstrap step