Skip to content

Add AssetIcon props documentation and Storybook story#3362

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/add-asseticon-props-list
Draft

Add AssetIcon props documentation and Storybook story#3362
Copilot wants to merge 2 commits intomainfrom
copilot/add-asseticon-props-list

Conversation

Copy link
Copy Markdown

Copilot AI commented Mar 5, 2026

AssetIcon had no documentation entry — its props were invisible to consumers since README.mdx only referenced Asset.tsx in its typescript frontmatter and had no <PropsTable> entry for AssetIcon.

Changes

  • README.mdx: Add ./src/AssetIcon/AssetIcon.tsx to typescript frontmatter; add AssetIcon to import examples; add ### AssetIcon usage section and <PropsTable of="AssetIcon" /> to Props API reference
  • examples/AssetIconExample.tsx (new): Example rendering all 11 asset type icons
  • stories/AssetIcon.stories.tsx (new): Storybook stories (Basic with controls, Overview showing all types) under Components/Asset/AssetIcon
  • AssetIcon.tsx: Simplify AssetIconProps — remove Omit<GeneratedIconProps, 'illustration' | 'ref'> since neither illustration nor ref exist on GeneratedIconProps; extend it directly instead
// Before
export interface AssetIconProps
  extends Omit<GeneratedIconProps, 'illustration' | 'ref'> {
  type?: AssetType;
}

// After
export interface AssetIconProps extends GeneratedIconProps {
  type?: AssetType;
}

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 5, 2026

⚠️ No Changeset found

Latest commit: 602ea45

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
forma-36 Ready Ready Preview Mar 5, 2026 11:21pm
forma-36-storybook Ready Ready Preview Mar 5, 2026 11:21pm

Request Review

Co-authored-by: sam-is-content <166558611+sam-is-content@users.noreply.github.com>
Copilot AI changed the title [WIP] Add full list of props for AssetIcon component Add AssetIcon props documentation and Storybook story Mar 5, 2026
@Lelith
Copy link
Copy Markdown
Collaborator

Sam Ashley (@sam-is-content) are you the owner of this PR? Could you add please some before/after screenshots for this?

@github-actions
Copy link
Copy Markdown

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 131.96 KB (0%) 2.7 s (0%) 33 ms (+234.43% 🔺) 2.7 s
Module 128.81 KB (0%) 2.6 s (0%) 26 ms (+163.69% 🔺) 2.7 s

@github-actions
Copy link
Copy Markdown

Marking pull request as stale since there was no activity for 30 days

@github-actions github-actions Bot added the stale Used to mark when there was no activity for a set period of time label Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale Used to mark when there was no activity for a set period of time

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants