Add active state to Button component#7
Merged
Mike Mitchell (m10l) merged 1 commit intomasterfrom Nov 22, 2018
Merged
Conversation
Mike Mitchell (m10l)
requested review from
Claus H (hollensteiner) and
Johannes Bugiel (wichniowski)
Claus H (hollensteiner)
approved these changes
Nov 22, 2018
Johannes Bugiel (wichniowski)
pushed a commit
that referenced
this pull request
Dec 10, 2018
Add active state to Button component
toniwowtscherk
added a commit
that referenced
this pull request
Apr 29, 2026
Adds screenshot comparison post-flight for Figma-to-code (Path C): capture source Figma design, render generated code, compare both, fix differences until converging. Eval showed V3 Path C missed sidebar, top nav, filter chips, and avatar columns because the design context alone doesn't describe page-level composition. Also syncs eval-driven fixes from product-design PR #7: corrected icon names (TrashIcon not TrashSimpleIcon), removed fabricated Skeleton.Row, fixed shadow token names. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds active states to Button components.
Some changes needed to be made to the transitions and the way we had defined backgrounds - you can't animate a gradient to a solid background as they're two different properties -
background-imageandbackground-color.