Skip to content

Add utils and notebook converting ADS-B to Flight DF#373

Open
jlee0523 wants to merge 1 commit into
contrailcirrus:mainfrom
jlee0523:adsb-flight-loading
Open

Add utils and notebook converting ADS-B to Flight DF#373
jlee0523 wants to merge 1 commit into
contrailcirrus:mainfrom
jlee0523:adsb-flight-loading

Conversation

@jlee0523
Copy link
Copy Markdown

@jlee0523 jlee0523 commented Feb 9, 2026

Changes

  • Add utility functions for imputing flight IDs into flight.py.
  • Add notebook demo-ing ADS-B fetching and flight loading end-to-end.

Tests

Affected tests pass, however some failures from pycontrails/datalib/google_forecast.py which is outside scope of these changes.

  • [] QC test passes locally (make test)
  • [] CI tests pass

Reviewer

@nickmasson

As part of open sourcing as much of the attributions code, here's the first part which is flight loading and flight ID assignment. Added util functions to Flight.py as it seemed the best match, but feel free to let me know if you would like it in its own separate file.

@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@nickmasson
Copy link
Copy Markdown
Contributor

@jlee0523 tagging @zebengberg & @thabbott here for opinion and review. They are the core maintainers of pycontrails -- best to coordinate review & contributions w/ them. Will link in via email as well.

If the vision here is to open-source the Google attributions pipeline & src code, it probably makes sense to architect out where best to contribute that content. I suspect pycontrails will be a suitable destination for some of that work (those core tools that are sufficiently use-case agnostic) -- will let @zebengberg chime in here on what pycontrails should and should not support -- in all likelihood we'll want to create a separate open-source project that houses the use-case/purpose-specific src code for the Google attribution work.

For instance we have open-sourced our processing service that backs our forecast APIs here: https://github.com/contrailcirrus/api-preprocessor
This implements, but is separate from, pycontrails.

We will likely also be open-sourcing the pipeline that builds our inventory of contrail impacts from historical ADS-B telemetry.

A similar approach may be suitable for contrails.org taking on open-sourcing the Google attributions source code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants