Skip to content

Updated Gitlab CI to use Python 3.8 instead of Python 3.7 #2794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
browniebroke merged 4 commits into from
Sep 7, 2020
Merged

Updated Gitlab CI to use Python 3.8 instead of Python 3.7 #2794

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b4748a
Updated .gitlab-ci.yml file to use python 3.8 instead of 3.7. This wo…
arnav13081994 Sep 5, 2020
fbc6e75
Added myself to list of contributors
arnav13081994 Sep 5, 2020
4410d9e
Made gitlab-ci use the same postgresql version as the user selected a…
arnav13081994 Sep 5, 2020
1676d1a
Removed entry from CONTRIBUTORS.md file
arnav13081994 Sep 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,13 @@ Listed in alphabetical order.
</td>
<td></td>
</tr>
<tr>
<td>Arnav Choudhury</td>
<td>
<a href="https://github.com/arnav13081994">arnav13081994</a>
</td>
<td></td>
</tr>
Copy link
Copy Markdown
Member

@browniebroke browniebroke Sep 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is now automatically generated, there was no need to update it.

It's a bit new so this step might still be mentioned somewhere, let me know if this is the case, we should update it.

Copy link
Copy Markdown
Contributor Author

@arnav13081994 arnav13081994 Sep 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. I thought this was supposed to be done manually. Should I remove that edit then and re-commit?

<tr>
<td>AsheKR</td>
<td>
Expand Down Expand Up @@ -1463,4 +1470,4 @@ guidance and advice.

- Jannis Leidel
- Nate Aune
- Barry Morrison
- Barry Morrison
6 changes: 3 additions & 3 deletions {{cookiecutter.project_slug}}/.gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ variables:

flake8:
stage: lint
image: python:3.7-alpine
image: python:3.8-alpine
before_script:
- pip install -q flake8
script:
- flake8

pytest:
stage: test
image: python:3.7
image: python:3.8
{% if cookiecutter.use_docker == 'y' -%}
image: docker/compose:latest
tags:
Expand All @@ -39,7 +39,7 @@ pytest:
tags:
- python
services:
- postgres:11
- postgres:{{ cookiecutter.postgresql_version }}
variables:
DATABASE_URL: pgsql://$POSTGRES_USER:$POSTGRES_PASSWORD@postgres/$POSTGRES_DB

Expand Down
⚡