Making docs file smaller by around 40% using multi-stage builds#2824
Closed
arnav13081994 wants to merge 15 commits intocookiecutter:masterfrom
Closed
Making docs file smaller by around 40% using multi-stage builds#2824arnav13081994 wants to merge 15 commits intocookiecutter:masterfrom
arnav13081994 wants to merge 15 commits intocookiecutter:masterfrom
Conversation
…storages-1.10-to-1.10.1
…e-5.2.1-to-5.3
Member
|
While this is a great improvement in #2815, especially for production image, I'm less convinced of the benefit of the docs image. This size improvement makes the |
Contributor
Author
|
@browniebroke Agreed. I did this just to be consistent with the Django Dockerfile. |
…sdk-0.17.4-to-0.17.5 Update sentry-sdk to 0.17.5
It looks like 4.4.7 has some issues with Redis broker: celery/celery#6285
Downgrade Celery to 4.4.6
This will make extending various signup and registration forms easier.
Comment on lines
+6
to
+12
| ## [2020-09-14] | ||
| ### Fixed | ||
| - Downgrade Celery to 4.4.6 ([#2829](https://api.github.com/repos/pydanny/cookiecutter-django/pulls/2829)) | ||
| ### Updated | ||
| - Update sentry-sdk to 0.17.5 ([#2828](https://api.github.com/repos/pydanny/cookiecutter-django/pulls/2828)) | ||
| - Update coverage to 5.3 ([#2826](https://api.github.com/repos/pydanny/cookiecutter-django/pulls/2826)) | ||
| - Update django-storages to 1.10.1 ([#2825](https://api.github.com/repos/pydanny/cookiecutter-django/pulls/2825)) |
Member
There was a problem hiding this comment.
Can you check how you've updated this PR? I think this shouldn't appear on it, it's already in master...
Contributor
Author
|
@browniebroke I forgot to merge upstream changes with my repo and that caused all of that. I will merge and raise another PR. Raised here: #2836 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I am proposing to use multi-stage builds for building the python part of Docs.
This can be done by installing all required OS and python dependencies and then to just copy over those files to the run stage. This would cause a nearly 35-40% reduction in size!
Checklist:
tests/test_cookiecutter_generation.pyis updated accordingly (especially if adding or updating a template option)Rationale
Smaller images are highly desirable because they would greatly reduce the time of re-deployment and deployment of containers and would also save a lot of time and money especially bandwidth costs.