Skip to content

Feature/add missing migrations file check#4973

Closed
arnav13081994 wants to merge 1 commit intocookiecutter:masterfrom
arnav13081994:feature/add_missing_migrations_file_check
Closed

Feature/add missing migrations file check#4973
arnav13081994 wants to merge 1 commit intocookiecutter:masterfrom
arnav13081994:feature/add_missing_migrations_file_check

Conversation

@arnav13081994
Copy link
Copy Markdown
Contributor

Description

Added a local pre-commit hook that fails in case the user forgot to commit a migration file.

Checklist:

  • I've made sure that tests are updated accordingly (especially if adding or updating a template option)
  • I've updated the documentation or confirm that my change doesn't require any updates

Rationale

@arnav13081994 arnav13081994 force-pushed the feature/add_missing_migrations_file_check branch from 89f3875 to 7d8bf4e Compare April 6, 2024 08:38
Copy link
Copy Markdown
Member

@browniebroke browniebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm -1 on this. I don't think pre-commit is the right place to check for that.

Also, from the template maintenance perspective, this file if free of templating logic, which enable us to run pre-commit autoupdate to keep versions up to date. Accepting this PR would break this workflow. I think the trade-off is not worth it.

@arnav13081994 arnav13081994 deleted the feature/add_missing_migrations_file_check branch April 6, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants