Skip to content

[Bug]: x/upgrade ParseInfo consider some values as URLs  #19686

@mhofman

Description

@mhofman

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

Trying to use values such as {} for upgrade-info results in error missing checksum query parameter.

The problem is that ParseInfo attempts to parse the upgrade info as a URL and consider it as such if no error is returned. However most strings can parse as a valid URL, especially relative ones.

It should at least check that the URL is absolute.

Cosmos SDK Version

0.46

How to reproduce?

$ gaiad tx gov submit-proposal software-upgrade foo --upgrade-height 123 --upgrade-info '{}'
Error: missing checksum query parameter

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions