Skip to content

refactor!: key presentation outside keyring#14151

Merged
tac0turtle merged 6 commits into
cosmos:mainfrom
Zondax:key-presentation-outside-keyring
Dec 7, 2022
Merged

refactor!: key presentation outside keyring#14151
tac0turtle merged 6 commits into
cosmos:mainfrom
Zondax:key-presentation-outside-keyring

Conversation

@JulianToledano

@JulianToledano JulianToledano commented Dec 5, 2022

Copy link
Copy Markdown
Contributor

Description

Closes:
#8046


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions Bot added C:CLI C:Keys Keybase, KMS and HSMs labels Dec 5, 2022
@JulianToledano JulianToledano marked this pull request as ready for review December 5, 2022 10:53
@JulianToledano JulianToledano requested a review from a team December 5, 2022 10:53

@tac0turtle tac0turtle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. im not sure we need to add tow changelog entries, but instead we can add a short sentence to the upgrading.md

@amaury1093 amaury1093 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@amaury1093 amaury1093 enabled auto-merge (squash) December 6, 2022 17:52
auto-merge was automatically disabled December 7, 2022 10:01

Head branch was pushed to by a user without write access

@tac0turtle tac0turtle enabled auto-merge (squash) December 7, 2022 10:02
@tac0turtle tac0turtle merged commit 6188f6e into cosmos:main Dec 7, 2022
@JulianToledano JulianToledano deleted the key-presentation-outside-keyring branch December 13, 2022 10:23
lukasz-zimnoch added a commit to mezo-org/mezod that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C:CLI C:Keys Keybase, KMS and HSMs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants