feat(mempool): priority nonce mempool option with tx replacement#14484
Merged
Conversation
JayT106
changed the title
julienrbrt
reviewed
Jan 5, 2023
kocubinski
reviewed
Jan 5, 2023
Contributor
|
So the intent here is to disallow tx replacement by |
alexanderbez
reviewed
Jan 5, 2023
Contributor
Author
Correct, the application can setup a rule to replace the transaction when the transaction has the same sender&nonce instead of always being replaced. |
Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com>
kocubinski
approved these changes
Jan 9, 2023
julienrbrt
approved these changes
Jan 10, 2023
julienrbrt
left a comment
julienrbrt
left a comment
Contributor
There was a problem hiding this comment.
lgtm!
Can we add a changelog?
Contributor
Author
done! |
0xbala-k
pushed a commit
to 0xbala-k/cosmos-sdk
that referenced
this pull request
Jan 12, 2023
…mos#14484) Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com>
Contributor
|
@Mergifyio backport release/v0.47.x |
Contributor
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Feb 22, 2023
) Co-authored-by: Matt Kocubinski <mkocubinski@gmail.com> (cherry picked from commit e6b849a) # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a mempool option for app setup of the tx replacement rule based on tx priority comparing logic. The current implementation is always allowing the transaction to be replaced when the mempool has a transaction with the same sender and the nonce.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change