feat: use same port for grpc-web and api server#14652
Merged
Merged
Conversation
ghost
requested review from
a team,
atheeshp and
facundomedica
and removed request for
a team
julienrbrt
force-pushed
the
julien/grpc-web
branch
from
c6ef7bd to
18b326a
Compare
tac0turtle
reviewed
Jan 17, 2023
tac0turtle
left a comment
tac0turtle
left a comment
Contributor
There was a problem hiding this comment.
Left one comment on core but otherwise looks good
| if cfg.API.EnableUnsafeCORS { | ||
| options = append(options, | ||
| grpcweb.WithOriginFunc(func(origin string) bool { | ||
| return true |
Contributor
There was a problem hiding this comment.
Do we want this to be hardcoded?
Contributor
Author
There was a problem hiding this comment.
I have kept the same behavior as before. The API constructor will look a bit weird if we add grpcweb options.
julienrbrt
commented
Jan 17, 2023
|
|
||
| // support old flags name for backwards compatibility | ||
| cmd.PersistentFlags().SetNormalizeFunc(func(f *pflag.FlagSet, name string) pflag.NormalizedName { | ||
| cmd.Flags().SetNormalizeFunc(func(f *pflag.FlagSet, name string) pflag.NormalizedName { |
julienrbrt
commented
Jan 17, 2023
|
|
||
| // support old flags name for backwards compatibility | ||
| cmd.PersistentFlags().SetNormalizeFunc(func(f *pflag.FlagSet, name string) pflag.NormalizedName { | ||
| f.SetNormalizeFunc(func(f *pflag.FlagSet, name string) pflag.NormalizedName { |
likhita-809
approved these changes
Jan 18, 2023
likhita-809
left a comment
likhita-809
left a comment
Contributor
There was a problem hiding this comment.
only few nits, otherwise lgtm
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
19 tasks
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
5 tasks
Closed
4 tasks
lukasz-zimnoch
added a commit
to mezo-org/mezod
that referenced
this pull request
Aug 7, 2024
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #8254
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change