refactor: make x/evidence a standalone module#14724
Merged
Merged
Conversation
added 3 commits
January 20, 2023 20:45
ghost
requested review from
a team,
JeancarloBarrios and
facundomedica
and removed request for
a team
julienrbrt
approved these changes
Jan 23, 2023
julienrbrt
left a comment
julienrbrt
left a comment
Contributor
There was a problem hiding this comment.
lgtm!
Other nits: can you add a module UPGRADING.md section mentioning the extraction of evidence, nft in their go.mod (and their renaming)? As well as a CHANGELOG, mentioning the extraction and renaming, in the main changelog and evidence/CHANGELOG? Additionally, the import grouping seems sometimes weird.
julienrbrt
reviewed
Jan 23, 2023
|
[Cosmos SDK - x/evidence] Kudos, SonarCloud Quality Gate passed!
|
julienrbrt
reviewed
Jan 23, 2023
julienrbrt
reviewed
Jan 23, 2023
julienrbrt
reviewed
Jan 23, 2023
julienrbrt
left a comment
julienrbrt
left a comment
Contributor
There was a problem hiding this comment.
@likhita-809, could you revert the permission of protocgen.sh to 755?
kocubinski
reviewed
Jan 23, 2023
added 3 commits
January 24, 2023 09:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: #14557
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change