refactor: rename nft to cosmosssdk.io/x/nft#14725
Conversation
ghost
requested review from
a team,
amaury1093 and
likhita-809
and removed request for
a team
| @@ -0,0 +1,2 @@ | |||
| // Package conv provides internal functions for convertions and data manipulation | |||
There was a problem hiding this comment.
Proposing to rename cosmos-sdk/internal to cosmos-sdk/unsafe in the SDK, so that it is public and other modules, like NFT, can use it, without having to copy the whole lib (we'll need to copy it for authz and upgrade otherwise).
There was a problem hiding this comment.
id ask what performance does this actually bring. in some cases its useful but for something that isn't don't often I don't think we need to do this unsafe tactic
There was a problem hiding this comment.
I think this actually goes away with collections. since store keys, where this is used, wont have it anymore. Id say lets leave as is and figure out how to remove it
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| import ( | ||
| "reflect" | ||
| "unsafe" |
Check failure
Code scanning / gosec
Blocklisted import unsafe
| package conv | ||
|
|
||
| import ( | ||
| "reflect" |
Check failure
Code scanning / gosec
Blocklisted import unsafe
| // to be used generally, but for a specific pattern to delete keys | ||
| // from a map. | ||
| func UnsafeBytesToStr(b []byte) string { | ||
| return *(*string)(unsafe.Pointer(&b)) |
Check warning
Code scanning / gosec
Use of unsafe calls should be audited
| func UnsafeStrToBytes(s string) []byte { | ||
| var buf []byte | ||
| sHdr := (*reflect.StringHeader)(unsafe.Pointer(&s)) | ||
| bufHdr := (*reflect.SliceHeader)(unsafe.Pointer(&buf)) |
Check warning
Code scanning / gosec
Use of unsafe calls should be audited
| // must not be altered after this function is called as it will cause a segmentation fault. | ||
| func UnsafeStrToBytes(s string) []byte { | ||
| var buf []byte | ||
| sHdr := (*reflect.StringHeader)(unsafe.Pointer(&s)) |
Check warning
Code scanning / gosec
Use of unsafe calls should be audited
tac0turtle
left a comment
tac0turtle
left a comment
There was a problem hiding this comment.
lgtm, thanks for handling this
|
@AmauryM https://github.com/cosmos/cosmos-sdk/actions/runs/3985932789/jobs/6833899304 |
Co-authored-by: Marko <marbar3778@yahoo.com>
4 participants
Description
Follow-up of #14634 (comment).
It has been decided that extracted modules must use a vanity url.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change